Solve related issues #107
Merged
Solve related issues #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 27, 2022
Codecov ReportBase: 91.89% // Head: 91.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 91.89% 91.47% -0.42%
==========================================
Files 41 41
Lines 3280 3342 +62
==========================================
+ Hits 3014 3057 +43
- Misses 266 285 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This also allows us to add colormap support for this Python -> Java conversion
gselzer
force-pushed
the
100-convert-imagedisplay-and-datasetview
branch
2 times, most recently
from
ea6da6d
to
add77a3
Compare
gselzer
force-pushed
the
100-convert-imagedisplay-and-datasetview
branch
from
add77a3
to
d1c6d91
Compare
gselzer
force-pushed
the
100-convert-imagedisplay-and-datasetview
branch
2 times, most recently
from
860cbb3
to
8b002d4
Compare
gselzer
force-pushed
the
100-convert-imagedisplay-and-datasetview
branch
from
8b002d4
to
36383aa
Compare
gselzer
force-pushed
the
100-convert-imagedisplay-and-datasetview
branch
from
36383aa
to
9b2b699
Compare
gselzer
added a commit
that referenced
this pull request
May 31, 2023
It was added with #107, but imagej-common now has converters such that the above converter should always win out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was originally designed to solve one issue, but it's actually going to solve (at least) two things when all's said and done.
Datasetsupport to solve Add support for conversion of ImageDisplay and DatasetView #100, so I figured I'd throw these changes in with.I was also debating solving #102 in this PR as well, as I had to make a couple changes to the functionality underlying layer selection during transfer. But I think those changes are correct so we can solve it in a separate PR.
TODO before merge:
Closes #100, #9