Switch SearchResult display to model/view paradigm #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
- Coverage 88.51% 88.28% -0.24%
==========================================
Files 53 53
Lines 4912 4925 +13
==========================================
Hits 4348 4348
- Misses 564 577 +13
☔ View full report in Codecov by Sentry. |
gselzer
force-pushed
the
284-search-results-should-show-icons-to-help-disambiguate
branch
3 times, most recently
from
2db5d2e
to
2d95b4f
Compare
We aren't implementing this behavior anymore (it's the default with QTreeView), so we don't need to test it.
...jpype is so smart!
gselzer
force-pushed
the
284-search-results-should-show-icons-to-help-disambiguate
branch
from
2d95b4f
to
5d97895
Compare
On MacOS, this prevents the categories from being highlighted
We haven't coded this behavior, so let's not test it!
gselzer
force-pushed
the
284-search-results-should-show-icons-to-help-disambiguate
branch
from
5d97895
to
173e336
Compare
|
This PR now loads all icons stored as resources within jars. It does not yet load icons from the web, mostly due to performance implications. Filed #296 to track that item. |
|
@gselzer Can you give an example of an icon referenced via a remote URL in this way? |
|
For example, the user icons from |
gselzer
force-pushed
the
284-search-results-should-show-icons-to-help-disambiguate
branch
from
1d509d4
to
1ee96af
Compare
gselzer
force-pushed
the
284-search-results-should-show-icons-to-help-disambiguate
branch
from
1ee96af
to
9b2d5a1
Compare
gselzer
deleted the
284-search-results-should-show-icons-to-help-disambiguate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the search result
QTreeWidgetto use Qt's model/view paradigm - not only is this a better separation of concerns, but it also makes it easier to do things like adding icons to search results.