Switch from HashSet to List for cross-platform deterministic node ord…

…ering and ids.
imazen · Jan 29, 2024 · f6e7a9e · f6e7a9e
1 parent e86fba4
commit f6e7a9e
Showing 1 changed file with 16 additions and 18 deletions.
diff --git a/src/Imageflow/Fluent/ImageJob.cs b/src/Imageflow/Fluent/ImageJob.cs
@@ -9,10 +9,7 @@
 namespace Imageflow.Fluent
 {
     [Obsolete("Use ImageJob instead")]
-    public class FluentBuildJob : ImageJob
-    {
-
-    }
+    public class FluentBuildJob : ImageJob;
 
     public class ImageJob: IDisposable
     {
@@ -260,18 +257,18 @@ private class MemoryStreamJsonProvider : IJsonResponseProvider
         }
 
 
-        private object BuildJsonWithPlaceholders()
-        {
-            var inputIo = _inputs.Select(pair =>
-                new {io_id = pair.Key, direction = "in", io = new {placeholder = (string?) null}});
-            var outputIo = _outputs.Select(pair =>
-                new {io_id = pair.Key, direction = "out", io = new {placeholder = (string?) null}});
-            return new
-            {
-                io = inputIo.Concat(outputIo).ToArray(),
-                framewise = ToFramewise()
-            };
-        }
+        // private object BuildJsonWithPlaceholders()
+        // {
+        //     var inputIo = _inputs.Select(pair =>
+        //         new {io_id = pair.Key, direction = "in", io = new {placeholder = (string?) null}});
+        //     var outputIo = _outputs.Select(pair =>
+        //         new {io_id = pair.Key, direction = "out", io = new {placeholder = (string?) null}});
+        //     return new
+        //     {
+        //         io = inputIo.Concat(outputIo).ToArray(),
+        //         framewise = ToFramewise()
+        //     };
+        // }
 
         private static ITemporaryFileProvider SystemTempProvider()
         {
@@ -485,18 +482,19 @@ internal async Task<IPreparedFilesystemJob> WriteJsonJobAndInputs(CancellationTo
 
 
 
-        private readonly HashSet<BuildItemBase> _nodesCreated = new HashSet<BuildItemBase>();
+        private readonly List<BuildItemBase> _nodesCreated = new List<BuildItemBase>(10);
 
 
 
         internal void AddNode(BuildItemBase n)
         {
             AssertReady();
 
-            if (!_nodesCreated.Add(n))
+            if (_nodesCreated.Contains(n))
             {
                 throw new ImageflowAssertionFailed("Cannot add duplicate node");
             }
+            _nodesCreated.Add(n);
             if (n.Canvas != null && !_nodesCreated.Contains(n.Canvas))// || n.Canvas.Builder != this))
             {
                 throw new ImageflowAssertionFailed("You cannot use a canvas node from a different ImageJob");