Fixed issue preventing headgear and top bone posing for some races #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
StoiaCode
reviewed
Feb 2, 2025
| public static IntPtr Territory { get; private set; } | ||
| public static IntPtr GPose { get; private set; } | ||
| public static IntPtr TimeAsm { get; private set; } | ||
| public static IntPtr Framework { get; set; } | ||
| public static IntPtr PlayerTargetSystem { get; set; } | ||
| public static IntPtr AnimationSpeedPatch { get; set; } | ||
| public static IntPtr KineDriverPosition { get; private set; } |
There was a problem hiding this comment.
Do you think its worthwhile to comment on what exactly the KineDriver things are for, even if we only have a brief description? As I understood right now they are only responsible for one thing and chances are it'll only get harder to understand what exactly they are for in the future.
There was a problem hiding this comment.
Yeah, good point. I ammended the latest commit to include a comment on the kinematic driver's use case.
There was a problem hiding this comment.
God damn it, Visual Studio nuked the includes. I just noticed 😆
ergoxiv
force-pushed
the
hotfix/visor-posing-fix
branch
from
a427629 to
f07b075
Compare
ergoxiv
force-pushed
the
hotfix/visor-posing-fix
branch
from
f07b075 to
fc5a677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
NopHookViewModeltoNopHook.kineDriverPosition,kineDriverRotation,kineDriverScale) to fix Helmet Bone #1422.