fix: code drift (umijs#12410)

imfenghuang · May 22, 2024 · f6abd77 · f6abd77
1 parent 82910f9
commit f6abd77
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/contributors.json b/contributors.json
@@ -46,5 +46,6 @@
   "qiguoq",
   "AmJunh",
   "MaxCDon",
-  "mysteryven"
+  "mysteryven",
+  "Jinbao1001"
 ]
diff --git a/packages/preset-umi/src/features/routePreloadOnLoad/routePreloadOnLoad.ts b/packages/preset-umi/src/features/routePreloadOnLoad/routePreloadOnLoad.ts
@@ -206,7 +206,7 @@ async function getRoutePathFilesMap(
 
 export default (api: IApi) => {
   let routeChunkFilesMap: IRouteChunkFilesMap;
-  let hashedPart = '.js';
+  let preloadJSFileExt = '.js';
   api.describe({
     enableBy: () =>
       // enable when package name available
@@ -237,7 +237,7 @@ export default (api: IApi) => {
           : // script mode
             [
               {
-                src: `${displayPublicPath}${PRELOAD_ROUTE_HELPER}${hashedPart}`,
+                src: `${displayPublicPath}${PRELOAD_ROUTE_HELPER}${preloadJSFileExt}`,
               },
             ];
       }
@@ -309,17 +309,20 @@ export default (api: IApi) => {
             }"${api.config.publicPath}"`,
           );
         if (api.config.hash) {
-          hashedPart = `.${createHash('md5')
+          preloadJSFileExt = `.${createHash('md5')
             .update(content)
             .digest('hex')
             .substring(0, 8)}.js`;
         }
 
         writeFileSync(
-          join(api.paths.absOutputPath, `${PRELOAD_ROUTE_HELPER}${hashedPart}`),
+          join(
+            api.paths.absOutputPath,
+            `${PRELOAD_ROUTE_HELPER}${preloadJSFileExt}`,
+          ),
           content,
-        ),
-          'utf-8';
+          'utf-8',
+        );
       }
     }
   });

diff --git a/packages/preset-umi/src/features/routePreloadOnLoad/utils.ts b/packages/preset-umi/src/features/routePreloadOnLoad/utils.ts
@@ -13,7 +13,7 @@ export interface IPreloadRouteFile {
 }
 
 export const PRELOAD_ROUTE_MAP_SCP_TYPE = 'umi-route-chunk-files-map';
-export const PRELOAD_ROUTE_HELPER = '_umi_route_preload_helper';
+export const PRELOAD_ROUTE_HELPER = 'preload_helper';
 
 export function getPreloadRouteFiles(
   path: string,