feat: add Persian font #318
Open
+750
−1,933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
imfing
requested changes
Mar 13, 2024
There was a problem hiding this comment.
Hi @Goudarz thank you for the PR, I like a idea to use a different and more preferred font for RTL lang.
In Hextra, I'd prefer to include resources like fonts when needed, and avoid using CDN.
The changes in styles.css from this PR will be applied to every site. In fact, from users perspective, what we have in the PR can be easily done in the custom.css file, right?
If we really want to make this an option to all end users, I would suggest putting it into a Hugo template partial, e.g. rtl-font.html, and include it when needed - when Persian lang is detected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the font of Vazirmatn for better readability of the content in Persian/Arabic language.