feat: add tooltips to cards #446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
imfing
requested changes
Aug 26, 2024
There was a problem hiding this comment.
Hi @joe128 thank you for the PR!
I appreciate the effort you’ve put into this. but I’m not sure if using the title attribute of a link as a tooltip is the best approach.
While allowing users to set a link title for a card is a good idea, I believe we should avoid using title as a tooltip as they serve different purposes.
|
The problem is that there is no "standard" for tooltips but most browsers interpret the title as a tooltip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial implementation of #444:
Added 2 Params to shortcode
card:linktooltip
tagtooltip
open TODOs
faandzh-cn