Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XRView to XRDepthInformation #50

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cabanier
Copy link
Member

@cabanier cabanier commented Sep 23, 2024

/tpac


Preview | Diff

@alcooper91
Copy link

Spoke offline yesterday and proposed some way to make this not a breaking change, suggested adding a new dictionary member that can be default false and true to indicate that the page is willing to handle this new information.

@Yonet Yonet removed the TPAC label Sep 24, 2024
@cabanier
Copy link
Member Author

This was discussed at TPAC and the consensus was that we should return an XRView instead with the information of the depth texture.

@cabanier cabanier changed the title Add projectionMatrix to XRDepthInformation Add XRView to XRDepthInformation Sep 30, 2024
@cabanier
Copy link
Member Author

Addresses #45

@alcooper91
Copy link

Overall this approach seems fine; except that I thought we had also discussed a way for the site to opt-in/acknowledge "Yes, I'm willing to handle this optional view" (Which may have been either a method to populate that view or to otherwise acquire it?)

@cabanier
Copy link
Member Author

Overall this approach seems fine; except that I thought we had also discussed a way for the site to opt-in/acknowledge "Yes, I'm willing to handle this optional view" (Which may have been either a method to populate that view or to otherwise acquire it?)

Yes, I didn't add that yet because the power outage stopped our meeting mid-way
I agree that this needs to be an opt-in

@cabanier
Copy link
Member Author

cabanier commented Oct 1, 2024

@alcooper91 do you want to address the optionality first before this is merged?

@alcooper91
Copy link

Yeah, I'd prefer to land that all at once so we don't have a weird in-between state of the spec.

I won't be able to attend the next meeting, but I'm happy to go along with whatever folks decide if you think we should continue the discussion at that?

@cabanier
Copy link
Member Author

cabanier commented Oct 1, 2024

/agenda discuss adding an optional feature that accomodates slower depth refresh rate

@probot-label probot-label bot added the agenda label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants