Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): do not reset fileCreatedDate #15650

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Conversation

C-Otto
Copy link
Contributor

@C-Otto C-Otto commented Jan 25, 2025

When marking an offline asset as online again, do not reset the fileCreatedAt value. This value contains the "true" date, copied from exif.dateTimeOriginal. If we overwrite this value, we'd need to run the metadata extraction job again. Instead, we just leave the old (and correct) value in place.

fixes #15640

@C-Otto C-Otto added external-library Issues related to external libraries date-time Issues with date/time/time zone labels Jan 25, 2025
@C-Otto C-Otto force-pushed the fix-library-reimport branch 2 times, most recently from 9444346 to 6bbcab7 Compare January 25, 2025 14:23
@C-Otto C-Otto marked this pull request as draft January 25, 2025 14:24
@C-Otto C-Otto force-pushed the fix-library-reimport branch 2 times, most recently from f538817 to 226aab7 Compare January 25, 2025 14:30
@C-Otto C-Otto marked this pull request as ready for review January 25, 2025 14:47
When marking an offline asset as online again, do not reset the
fileCreatedAt value. This value contains the "true" date, copied
from exif.dateTimeOriginal. If we overwrite this value, we'd need
to run the metadata extraction job again. Instead, we just leave
the old (and correct) value in place.

fixes #15640
@C-Otto C-Otto force-pushed the fix-library-reimport branch from 226aab7 to c0397fd Compare January 25, 2025 19:23
@alextran1502
Copy link
Contributor

Thannks!

@alextran1502 alextran1502 merged commit 64b92cb into main Jan 25, 2025
36 checks passed
@alextran1502 alextran1502 deleted the fix-library-reimport branch January 25, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix date-time Issues with date/time/time zone external-library Issues related to external libraries 🗄️server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"fileCreatedAt" overwritten after library reimport
4 participants