analyze: implement Box<T> rewrites #1106
Conversation
spernsteiner
force-pushed
the
analyze-rewrite-box-base
branch
from
8a8bc96 to
b3aecb0
Compare
spernsteiner
force-pushed
the
analyze-rewrite-box
branch
from
e1af765 to
6a091e1
Compare
| ) | ||
| } | ||
| mir_op::RewriteKind::DynOwnedWrap => { | ||
| Rewrite::Call("std::result::Result::<_, ()>::Ok".to_string(), vec![hir_rw]) |
There was a problem hiding this comment.
Couldn't this just be an Option?
There was a problem hiding this comment.
It could, but DynOwned can be composed with Option<T> if we encounter a nullable owned pointer, and Option<DynOwned<T>> is clearer than Option<Option<T>>. But c2rust-analyze doesn't yet have a run-time support library where we could define DynOwned<T>, so for now we use the somewhat ugly Result<T, ()> in place of DynOwned<T>.
There was a problem hiding this comment.
Might be useful to add a comment.
There was a problem hiding this comment.
Added a comment on the translation of DynOwned types: 95d4038
spernsteiner
force-pushed
the
analyze-rewrite-box
branch
from
6a091e1 to
3cd8c2d
Compare
|
Looks like the Darwin CI error here is the same issue that's being fixed in #1146. Once that's merged, I'll rebase this and try the CI again. |
spernsteiner
force-pushed
the
analyze-rewrite-box
branch
from
3cd8c2d to
82e989c
Compare
This avoids the need for an `extern crate alloc` when testing rewritten code.
spernsteiner
force-pushed
the
analyze-rewrite-box
branch
from
82e989c to
95d4038
Compare
This branch adds rewrites to convert pointers with the
FREEpermission intoBox<T>. This follows the dynamic ownership tracking proposal in #1097.Specific changes:
dyn_owned: boolfield toTypeDesc, which indicates that the pointer type should be wrapped in a dynamic ownership wrapper.ZeroizeTypehandling to support zero-initializing some pointer types (necessary to allowmalloc/callocof structs that contain pointers).Boxanddyn_ownedrelated casts inmir_opandrewrite::expr::convert.malloc,calloc,free, andrealloc.