Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #1192

Merged
merged 2 commits into from
Jan 28, 2025
Merged

fix typos #1192

merged 2 commits into from
Jan 28, 2025

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Dec 20, 2024

No description provided.

kkysen
kkysen previously approved these changes Dec 20, 2024
Copy link
Contributor

@fw-immunant fw-immunant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in assembly.rs incorrectly alters the sense of the comment there. Please revert that hunk.

c2rust-transpile/src/translator/assembly.rs Outdated Show resolved Hide resolved
@jayvdb
Copy link
Contributor Author

jayvdb commented Dec 20, 2024

I have also added a .typos.toml , config for https://crates.io/crates/typos-cli ; happy to remove if not desired, or move into a .config/ in order to reduce top level files.

@jayvdb jayvdb requested a review from fw-immunant December 23, 2024 07:25
Copy link
Contributor

@fw-immunant fw-immunant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@fw-immunant fw-immunant merged commit adcc29c into immunant:master Jan 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants