-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init core status api generation #17
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 14.09% 14.22% +0.12%
==========================================
Files 40 41 +1
Lines 6618 6693 +75
==========================================
+ Hits 933 952 +19
- Misses 5544 5599 +55
- Partials 141 142 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Done with this. The responses basically look like:
Two notes: With lightning, the daemon technically has support for multiple lightning nodes, so this lists the pubkey and whether or not the connection is active with the lightning node. With the "relay check", the daemon does not treat relays any different than normal peers when it comes to connections. The daemon is very indifferent to have 0, 1, or many relays that the user might want to check on. So, this lists all peers that there's a web socket connection with. If the browser wants to decide whether or not the connection to the user's relay is good, you'll have to do client side filtering with the relay DID that the browser has configured for the user. @markhandlersec let me know if that makes sense and if that is acceptable. |
@tonyimpervious love it! @markcryptohash and I are reviewing it right now, will approve afterwards. 👊 |
works as expected |
TODO: