Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 02-batch-ingestion.ipynb #109

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

petermarshallio
Copy link
Collaborator

@petermarshallio petermarshallio commented Jul 9, 2024

Major amendments to shorten this notebook and make it less arduous to complete, as well as fixing an issue with one of the SQL statements.

Fix for #114

Major amendments to shorten this notebook and make it less arduous to complete, as well as fixing an issue with one of the SQL statements.
@petermarshallio petermarshallio requested a review from hevansDev July 9, 2024 10:16
Copy link
Contributor

@hevansDev hevansDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good an works great, just one small note

notebooks/02-ingestion/02-batch-ingestion.ipynb Outdated Show resolved Hide resolved
@petermarshallio petermarshallio merged commit 1cf99db into main Aug 1, 2024
1 check passed
@petermarshallio petermarshallio deleted the 202407-batch-ingestion-notebook-fix branch August 1, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants