[Tests] no-named-as-default: add cases for invalid code

import-js · Sep 9, 2024 · 3a0af7e · 3a0af7e
1 parent 7dfee21
commit 3a0af7e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/src/rules/no-named-as-default.js b/src/rules/no-named-as-default.js
@@ -35,7 +35,8 @@ module.exports = {
       }
 
       if (!importedModule.hasDefault) {
-        // Impossible: how could we even get here? Kept in case of unexpected regressions.
+        // The rule is triggered for default imports/exports, so if the imported module has no default
+        // this means we're dealing with incorrect source code anyway
         return;
       }
 

diff --git a/tests/files/no-named-as-default/no-default-export.js b/tests/files/no-named-as-default/no-default-export.js
@@ -0,0 +1 @@
+export const foobar = 4;
diff --git a/tests/src/rules/no-named-as-default.js b/tests/src/rules/no-named-as-default.js
@@ -47,6 +47,10 @@ ruleTester.run('no-named-as-default', rule, {
     test({
       code: 'import variable from "./no-named-as-default/misleading-re-exports.js";',
     }),
+    test({
+      // incorrect import
+      code: 'import foobar from "./no-named-as-default/no-default-export.js";',
+    }),
     // same tests, but for exports
     test({
       code: 'export something from "./no-named-as-default/re-exports.js";',
@@ -66,6 +70,10 @@ ruleTester.run('no-named-as-default', rule, {
       code: 'export variable from "./no-named-as-default/misleading-re-exports.js";',
       parser: parsers.BABEL_OLD,
     }),
+    test({
+      code: 'export foobar from "./no-named-as-default/no-default-export.js";',
+      parser: parsers.BABEL_OLD,
+    }),
 
     ...SYNTAX_CASES,
   ),