avoid traversing subgraphs outside of my scc

import-js · Aug 23, 2024 · 70ea2c6 · 70ea2c6
1 parent 06d8ec3
commit 70ea2c6
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/rules/no-cycle.js b/src/rules/no-cycle.js
@@ -119,6 +119,9 @@ module.exports = {
         traversed.add(m.path);
 
         for (const [path, { getter, declarations }] of m.imports) {
+          // If we're in different SCCs, we can't have a circular dependency
+          if (scc[myPath] !== scc[path]) { continue; }
+
           if (traversed.has(path)) { continue; }
           const toTraverse = [...declarations].filter(({ source, isOnlyImportingTypes }) => !ignoreModule(source.value)
             // Ignore only type imports