-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[import/order] Regression in type
behavior with parent
and sibling
#2683
Comments
I think this is a duplicate of #2682? |
@ljharb I'm not sure because the non- |
cc @Pearce-Ropion in case this is related, but if not, it'd still be great to tackle it in the same PR |
Hmm, this is caused by the same alphabetical sorting issue but cannot be fixed in the same way unless we add groups for types. |
|
Quick progress update, I have a fix for this working locally. I'm working on adding a few more unit test cases to maintain code coverage. I should have a PR up by the end of the week. |
I've put up #2721. I think it needs more unit testing but figured I'd get the PR out there |
We have a complex
import/order
config and are seeing some new behavior with ourtype
imports on v2.27.5 where previously sorted parent → sibling type imports want to now be sorted as sibling → parent.Before
After
The text was updated successfully, but these errors were encountered: