Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump #732

Closed
wants to merge 5 commits into from
Closed

chore(deps): bump #732

wants to merge 5 commits into from

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Jan 18, 2023 •
edited
Loading

🧰 Changes

Before:

Package                Current  Wanted  Latest  Location                            Depended by
@readme/eslint-config   10.3.2  10.4.5  10.4.5  node_modules/@readme/eslint-config  rdme
@types/jest             29.2.5  29.2.6  29.2.6  node_modules/@types/jest            rdme
chalk                    4.1.2   4.1.2   5.2.0  node_modules/chalk                  rdme
config                   3.3.8   3.3.9   3.3.9  node_modules/config                 rdme
configstore              5.0.1   5.0.1   6.0.0  node_modules/configstore            rdme
eslint                  8.31.0  8.32.0  8.32.0  node_modules/eslint                 rdme
jest-extended            3.2.1   3.2.3   3.2.3  node_modules/jest-extended          rdme
nock                    13.2.9  13.3.0  13.3.0  node_modules/nock                   rdme
node-fetch               2.6.7   2.6.8   3.3.0  node_modules/node-fetch             rdme
oas                     20.3.0  20.4.0  20.4.0  node_modules/oas                    rdme
ora                      5.4.1   5.4.1   6.1.2  node_modules/ora                    rdme
prettier                 2.8.1   2.8.3   2.8.3  node_modules/prettier               rdme
simple-git              3.15.1  3.16.0  3.16.0  node_modules/simple-git             rdme
ts-jest                 29.0.3  29.0.5  29.0.5  node_modules/ts-jest                rdme
type-fest                3.5.1   3.5.2   3.5.2  node_modules/type-fest              rdme

After:

Package      Current  Wanted  Latest  Location                  Depended by
chalk          4.1.2   4.1.2   5.2.0  node_modules/chalk        rdme
configstore    5.0.1   5.0.1   6.0.0  node_modules/configstore  rdme
node-fetch     2.6.8   2.6.8   3.3.0  node_modules/node-fetch   rdme
ora            5.4.1   5.4.1   6.1.2  node_modules/ora          rdme

@kanadgupta kanadgupta added the dependencies Pull requests that update a dependency file label Jan 18, 2023
@kanadgupta kanadgupta changed the title Bump deps 1 18 2023 chore(deps): bump Jan 18, 2023
@kanadgupta kanadgupta marked this pull request as ready for review January 18, 2023 20:11
erunion
erunion reviewed Jan 18, 2023
View reviewed changes
src/cmds/validate.ts
import type { Options } from './openapi/validate';
import type { CommandOptions } from '../lib/baseCommand';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, this reorder shouldn't have happened.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol yikes... could this be another bug with that import plugin? i can hold off

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's just type imports that are this way. I'll update that ticket I had

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like they're already on it. Feel free to pull this bump in anyways and we can change this back when they fix it.

Copy link
Member Author

@kanadgupta kanadgupta Jan 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh I'll just convert this to a draft in the meantime, I'd rather keep the diff minimal

for posterity: waiting on this to be fixed: import-js/eslint-plugin-import#2683

@kanadgupta kanadgupta marked this pull request as draft January 18, 2023 21:26
@kanadgupta kanadgupta closed this Jan 23, 2023
@kanadgupta kanadgupta deleted the bump-deps-1-18-2023 branch January 23, 2023 15:41
@kanadgupta kanadgupta restored the bump-deps-1-18-2023 branch January 23, 2023 15:46
@kanadgupta kanadgupta reopened this Jan 23, 2023
@kanadgupta
Copy link
Member Author

see #739

@kanadgupta kanadgupta closed this Jan 31, 2023
@kanadgupta kanadgupta deleted the bump-deps-1-18-2023 branch January 31, 2023 18:45
@kanadgupta kanadgupta mentioned this pull request Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion erunion left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanadgupta @erunion