[New] extensions: add auto fixer!
#2593
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @ljharb / |
ljharb
reviewed
Nov 17, 2022
| @@ -151,6 +159,7 @@ ruleTester.run('extensions', rule, { | |||
| invalid: [ | |||
| test({ | |||
| code: 'import a from "a/index.js"', | |||
| output: 'import a from "a/index"', | |||
There was a problem hiding this comment.
this isn't a safe autofix unless we can validate that a/index and a/index.js resolve to the same thing.
if we can't add that validation using custom resolvers, then this would need to be a suggestion instead of an autofix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doesn't seem to work in all cases - fails silently in some cases as you can see in the tests where there are expected errors but
ouput===code.first time writing a fixer so I hope I'm doing it right.
adding the missing file extension does not support query params. would be easier with node's
path, I found it hard to work with the URL since it would not differentiate betweenxand./x, but maybe i was holding it wrong