Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslints #2871

Closed
wants to merge 1 commit into from
Closed

Fix eslints #2871

wants to merge 1 commit into from

Conversation

OlivierZal
Copy link

@ljharb, to make tests more readable...

@ljharb
Copy link
Member

ljharb commented Sep 2, 2023

is there anything enforcing this?

@OlivierZal
Copy link
Author

Not really, I just read the test results from my other PR.

@ljharb
Copy link
Member

ljharb commented Sep 2, 2023

These formatting changes should be enforced with eslint rules if we're going to make them en masse.

@OlivierZal
Copy link
Author

I fixed all the warnings I saw there: https://github.com/import-js/eslint-plugin-import/actions/runs/6049563566/job/16417081560#step:4:1 (except the no-console one).

@OlivierZal OlivierZal closed this Sep 2, 2023
@OlivierZal OlivierZal deleted the olivierzal/fix_eslints branch September 2, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants