Feature: no duplicates require

[Pandemic1617]

implements detection of duplicate require imports

resolves #2925

Note that auto fix isn't implemented

[ljharb]

Can we add some tests with a function that's called "require" but isn't the global one?

[Pandemic1617]

Can we add some tests with a function that's called "require" but isn't the global one?

const require = (x) => {};

const a = require("./a.js");

This require would be detected as the global require even though it isn't.

This is indeed a limitation of my implementation but I thought it would be acceptable since the following rules also have the same limitation:

• no-dynamic-require
• no-amd
• max-dependencies
• no-self-import
• no-relative-packages

[ljharb]

Hmm - are there no rules that dont have the limitation?

[Pandemic1617]

I am not aware of any and even the moduleVisitor util has that limitation