[Fix/New] Node resolver: Try to use require.resolve when suitable
#2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
force-pushed
the
node-require-resolve
branch
from
d440083
to
d03e353
Compare
|
Rebased to fix conflicts from 2d38b33. |
akx
force-pushed
the
node-require-resolve
branch
from
d03e353
to
df18ba7
Compare
akx
force-pushed
the
node-require-resolve
branch
from
df18ba7
to
1592741
Compare
|
I think there's a lot of subtleties here, and we'd need lots of tests to cover this behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to have the Node resolver use
require.resolvewhen possible; among other things, this enables support for packages that only haveexports.main(when the underlying Node.js version supports them) (see #2132).I don't know if there are subtleties to this, but I feel like this could work.