Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for node: protocol #3023

Conversation

GoldStrikeArch
Copy link

Fix to this issue
Added plugin 'prefer-node-builtin-imports'.
The plugin is based on 'prefer-node-protocol' rule from 'eslint-plugin-unicorn' plugin and contains 0 dependencies.
All test cases are taken from eslint-plugin-unicorn_test

Copy link

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't achieve anything for consumers, it just lints this project, and we do not actually prefer the node protocol here. The linked issue is about a rule, in this plugin, that allows this to be configured.

@ljharb ljharb marked this pull request as draft July 3, 2024 21:55
@ljharb ljharb closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants