Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack resolver: Simplify loop #3029

Merged
merged 1 commit into from
Aug 27, 2024
Merged

webpack resolver: Simplify loop #3029

merged 1 commit into from
Aug 27, 2024

Conversation

fregante
Copy link
Contributor

This PR reduces the amount of code run by using a plain for loop with early return. I was hesitant to make the change at first but I noticed that there are a lot of similar loops in the code so it shouldn't be a problem to use the same here

@fregante fregante changed the title Simplify loop webpack resolver: Simplify loop Jul 14, 2024
resolvers/webpack/index.js Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.91%. Comparing base (bdff75d) to head (db8b95d).
Report is 2 commits behind head on main.

Files Patch % Lines
resolvers/webpack/index.js 37.50% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3029       +/-   ##
===========================================
+ Coverage   85.33%   95.91%   +10.57%     
===========================================
  Files          78       78               
  Lines        3300     3302        +2     
  Branches     1160     1162        +2     
===========================================
+ Hits         2816     3167      +351     
+ Misses        484      135      -349     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

socket-security bot commented Aug 9, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@ljharb ljharb merged commit db8b95d into import-js:main Aug 27, 2024
308 of 309 checks passed
@fregante fregante deleted the loop branch August 27, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants