Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] order: codify invariants from docs into config schema #3152

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

[Fix] order: codify invariants from docs into config schema #3152

wants to merge 13 commits into from
+3,746 −245

Conversation

Xunnamius
Copy link
Contributor

Updating schema wrt #3127 (comment)

@Xunnamius
[New] order: add newlines-between-types option to control intragr…
4016f3e 
…oup sorting of type-only imports

Closes import-js#2912
Closes import-js#2347
Closes import-js#2441
Subsumes import-js#2615
@Xunnamius
fix(src): codify dependency between "newlines-between-types" and "sor…
3d3b98b 
…tTypesGroup" in rule schema
@Xunnamius
fix: [import/order] ensure arcane imports do not cause undefined beha…
3c82177 
…vior
@Xunnamius
test(tests): use backwards-compatible node imports specifiers
40cf277
@Xunnamius
feat: [import/order] collapse excess spacing for aesthetically pleasi…
ca9267e 
…ng imports via `consolidateIslands`
@Xunnamius
test(tests): add tests that got left on the cutting-room floor
f6758e7
@Xunnamius
chore: linting pass
020efb1
@Xunnamius
test(tests): use backwards-compatible node imports specifiers
dab5b0d
@Xunnamius
test(tests): account for different error handling behavior from diffe…
1bdb5d1 
…rent eslint versions
@Xunnamius
fix: ensure consolidateIslands overrides both newlines-between and ne…
dece12e 
…wlines-between-types when in conflict
@Xunnamius
fix(src): codify dependency between "newlines-between-types"/"newline…
3c4c3f2 
…s-between" and "consolidateIslands" in rule schema
@Xunnamius
fix: prohibit nonsensical configurations using the schema
d1230fb
@Xunnamius
test: fix erroneously invalid options in "valid" tests identified by …
42252c4 
…stricter schema
@ljharb
Copy link
Member

ljharb commented Jan 26, 2025

This PR seems to have too much stuff in it - but either way, if a rule or option is already released, its schema can’t be tightened further.

@Xunnamius
Copy link
Contributor Author

Xunnamius commented Jan 27, 2025 •
edited
Loading

@ljharb It seems like it has a lot because it's on top of the consolidateIslands PR (rather than main so the schema changes can run against the latest tests), but the two new commits are tiny and only touch the schema and two tests. I can pull the lines around dependencies/consolidateIslands one commit up into the consolidateIslands PR if desired :) EDIT: I can also rebase onto main and decouple from the other PRs, but not hitting all the new tests plus no direct tests of the schema makes me a bit nervous.

As for the tightening of existing options, I assume you're talking about lines 865 and 866 for pathGroupsExcludedImportTypes? I can revert those. I did add a comment to the groups schema warning that additional validation happens elsewhere, and added two newlines to the named schema for consistency, but those changes should be just cosmetic.

@ljharb
Copy link
Member

ljharb commented Jan 27, 2025

In that case, I'll wait to review this since it needs to wait on #3129

@ljharb ljharb marked this pull request as draft January 27, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xunnamius @ljharb