refactor: refer to rule id using static id

impress-org · Jul 31, 2023 · de947e6 · de947e6
1 parent 5a4385b
commit de947e6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/src/Framework/FieldsAPI/File.php b/src/Framework/FieldsAPI/File.php
@@ -21,7 +21,6 @@ class File extends Field
     use Concerns\HasEmailTag;
     use Concerns\HasHelpText;
     use Concerns\HasLabel;
-    use Concerns\AllowMultiple;
 
     const TYPE = 'file';
 
@@ -30,9 +29,9 @@ class File extends Field
      */
     public function maxSize(int $maxSize): File
     {
-        if ($this->hasRule('file')) {
+        if ($this->hasRule(FileRule::id())) {
             /** @var FileRule $rule */
-            $rule = $this->getRule('file');
+            $rule = $this->getRule(FileRule::id());
             $rule->size($maxSize);
         }
 
@@ -47,12 +46,12 @@ public function maxSize(int $maxSize): File
      */
     public function getMaxSize(): int
     {
-        if (!$this->hasRule('file')) {
+        if (!$this->hasRule(FileRule::id())) {
             return wp_max_upload_size();
         }
 
         /** @var FileRule $rule */
-        $rule = $this->getRule('file');
+        $rule = $this->getRule(FileRule::id());
 
         return $rule->getSize();
     }

diff --git a/src/Framework/ValidationRules/Rules/File.php b/src/Framework/ValidationRules/Rules/File.php
@@ -44,7 +44,7 @@ public function size(int $size): ValidationRule
 
         return $this;
     }
-    
+
     /**
      * @unreleased
      **/

diff --git a/src/Framework/ValidationRules/ValidationRulesServiceProvider.php b/src/Framework/ValidationRules/ValidationRulesServiceProvider.php
@@ -5,7 +5,6 @@
 namespace Give\Framework\ValidationRules;
 
 use Give\Framework\ValidationRules\Rules\AllowedTypes;
-use Give\Framework\ValidationRules\Rules\File;
 use Give\ServiceProviders\ServiceProvider;
 use Give\Vendors\StellarWP\Validation\ValidationRulesRegistrar;
 
@@ -24,8 +23,7 @@ public function register()
     public function boot()
     {
         give(ValidationRulesRegistrar::class)->register(
-            AllowedTypes::class,
-            File::class
+            AllowedTypes::class
         );
     }
 }