Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Scroll Stripe checkout modal into view for Legacy + Multistep forms #6789

Merged
merged 5 commits into from
Aug 2, 2023

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Apr 28, 2023

Resolves #6788

Description

This PR adds functionality to scroll the Stripe checkout modal into view when the user clicks the purchase button. The checkout modal will now be visible to the user, regardless of their screen size. This fix currently only works for legacy & classic templates.

Affects

Stripe checkout modal

Visuals

Testing Instructions

  • Create a form and set Stripe Checkout as a payment option.
  • Begin the donation process on a mobile device, a long donation form, or with altered viewports on a desktop.
  • Fill out the form until you reach the second to last step before payment.
  • Click on the "Donate Now" button.
  • The Stripe modal should scroll into view.
  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

Copy link
Contributor

@JasonTheAdams JasonTheAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @JoshuaHungDinh! This should work. I just notice a super minor formatting thing.

assets/src/js/frontend/give-stripe-elements.js Outdated Show resolved Hide resolved
@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed.

@github-actions github-actions bot added the Stale label Jul 22, 2023
@jonwaldstein
Copy link
Contributor

@JoshuaHungDinh what's the status of this?

@github-actions github-actions bot removed the Stale label Jul 29, 2023
@JoshuaHungDinh
Copy link
Contributor Author

@jonwaldstein So there was some back and forth on the PR because it would only scroll the stripe modals for Legacy and Multistep form. It would not work on classic. We are left with two options. Either merge a partial fix or close it out. Heres the last conversations. I think the verdict was a little unclear due to how much time had passed. What do you think? https://app.asana.com/0/1203193833018151/1204508757292153

@jonwaldstein
Copy link
Contributor

@JoshuaHungDinh gotchya, I would go with partial fix and change the PR title/scope to state that it's just for legacy & multistep. Classic template is still the least used one so at least this would be fixed for folks using the other templates and we can circle back if need be.

@JoshuaHungDinh JoshuaHungDinh changed the title Feature: Scroll Stripe checkout modal into view on all form lengths and screen sizes Feature: Scroll Stripe checkout modal into view for Legacy + Multistep forms Aug 2, 2023
@JoshuaHungDinh JoshuaHungDinh merged commit b9db161 into develop Aug 2, 2023
16 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the fix/stripe-checkout-modal-placement branch August 2, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stripe Checkout modal should immediately be visible on all views and form lengths
4 participants