-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Scroll Stripe checkout modal into view for Legacy + Multistep forms #6789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @JoshuaHungDinh! This should work. I just notice a super minor formatting thing.
This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed. |
@JoshuaHungDinh what's the status of this? |
@jonwaldstein So there was some back and forth on the PR because it would only scroll the stripe modals for Legacy and Multistep form. It would not work on classic. We are left with two options. Either merge a partial fix or close it out. Heres the last conversations. I think the verdict was a little unclear due to how much time had passed. What do you think? https://app.asana.com/0/1203193833018151/1204508757292153 |
@JoshuaHungDinh gotchya, I would go with partial fix and change the PR title/scope to state that it's just for legacy & multistep. Classic template is still the least used one so at least this would be fixed for folks using the other templates and we can circle back if need be. |
Resolves #6788
Description
This PR adds functionality to scroll the Stripe checkout modal into view when the user clicks the purchase button. The checkout modal will now be visible to the user, regardless of their screen size. This fix currently only works for legacy & classic templates.
Affects
Stripe checkout modal
Visuals
Testing Instructions
@unreleased
tags included in DocBlocks