Fix: Handle boolean values from get_theme_support in MultiFormGoal/ProgressBar

[JoshuaHungDinh]

Resolves #6851

Description

It is possible that 'get_theme_support' returns a false value if explicitly defined in a theme.

If $editorColorPalette is a boolean (either true or false), attempting to use array_shift() on it will result in a type error.

Affects

Multi Form Goal Progress Bar

Testing Instructions

• Switch to PHP 8+
• Use a theme that defines add_theme_support('editor-color-palette', false);
• Add the MultiFormGoal block

Pre-review Checklist

• Acceptance criteria satisfied and marked in related issue
• Relevant @unreleased tags included in DocBlocks
• Includes unit tests
• Reviewed by the designer (if follows a design)
• Self Review of code and UX completed

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1205176602055571

[jonwaldstein]

@JoshuaHungDinh thanks for adding this, please send to QA

[kjohnson]

Following up - has this change been through QA?

[JoshuaHungDinh]

@kjohnson, Yes but another cooldown item regarding a different issue with the multiformgoal block is keeping QA from being able to manually test it. I checked it out and believe its in regards to react-select in the block editor. We can add react and react-dom to the webpack externals which will fix it. I was hesitant though as I was not sure if it would introduce any breaking changes and so the item is sitting in a deferred status at the moment. Here a link to the additional issue : https://feedback.givewp.com/bug-reports/p/forms-cannot-be-selected-in-multi-form-goal-block

[kjohnson]

@JoshuaHungDinh that works for me! And of course now I see the Asana link in the PR description - whoops!

Adding a link to the QA comment for cross-reference: https://app.asana.com/0/0/1205176602055571/1205204829262848/f

[joeczucha]

Just checking whether this was ever merged, as were holding off updating the plugin until there is a fix in place. Thanks

[JoshuaHungDinh]

@joeczucha, thanks for checking in. We have another developer integrating some changes to id filtering for this particular block in order for it to properly work. We expect to have those updates soon & once merged this PR can follow

I will be sure to reach out once this issue has been resolved.

[rickalday]

Passed manual QA tests