Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add WordPressLibraries to manage WP_Background_Process #6856

Merged
merged 11 commits into from
Aug 9, 2023

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Jul 26, 2023

Description

This pull request introduces organizational changes and a new directory to handle the deprecated WP_Background_Process and WP_Async_Request classes more efficiently. Additionally, this addresses potential conflicts with other plugins using the same classes, specifically a fatal error experienced with the 3rd party plugin "RankMath" and our Give-Zapier plugin.

The primary motivation behind these changes is to eliminate conflicts arising from the loading of the deprecated classes without considering the plugin's scope. By creating a new namespace directory to manager the WP Background Process we can make it easier to manage any future conflicts with third party plugins.

The new namespaced classes can be found with the Framework directory, under WordPressLibraries.

Reference: https://github.com/impress-org/give-zapier/pull/63

Testing Instructions

Please see referenced PR.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

src/Framework/WordPressLibraries/WPBackgroundProcess.php Outdated Show resolved Hide resolved
src/Framework/WordPressLibraries/WPAsyncRequest.php Outdated Show resolved Hide resolved
includes/class-give-background-updater.php Outdated Show resolved Hide resolved
includes/libraries/wp-async-request.php Outdated Show resolved Hide resolved
includes/libraries/wp-background-process.php Outdated Show resolved Hide resolved
includes/class-give-background-updater.php Outdated Show resolved Hide resolved
includes/class-give-async-process.php Outdated Show resolved Hide resolved
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ready for QA

@JoshuaHungDinh JoshuaHungDinh merged commit 855b78c into develop Aug 9, 2023
16 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the feature/namespace-wp-background-process branch August 9, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants