-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add WordPressLibraries to manage WP_Background_Process #6856
Merged
JoshuaHungDinh
merged 11 commits into
develop
from
feature/namespace-wp-background-process
Aug 9, 2023
Merged
Feature: Add WordPressLibraries to manage WP_Background_Process #6856
JoshuaHungDinh
merged 11 commits into
develop
from
feature/namespace-wp-background-process
Aug 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwaldstein
requested changes
Jul 28, 2023
jonwaldstein
requested changes
Jul 31, 2023
Co-authored-by: Jon Waldstein <[email protected]>
Co-authored-by: Jon Waldstein <[email protected]>
jonwaldstein
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ready for QA
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces organizational changes and a new directory to handle the deprecated
WP_Background_Process
andWP_Async_Request
classes more efficiently. Additionally, this addresses potential conflicts with other plugins using the same classes, specifically a fatal error experienced with the 3rd party plugin "RankMath" and our Give-Zapier plugin.The primary motivation behind these changes is to eliminate conflicts arising from the loading of the deprecated classes without considering the plugin's scope. By creating a new namespace directory to manager the WP Background Process we can make it easier to manage any future conflicts with third party plugins.
The new namespaced classes can be found with the Framework directory, under WordPressLibraries.
Reference: https://github.com/impress-org/give-zapier/pull/63
Testing Instructions
Please see referenced PR.
Pre-review Checklist
@unreleased
tags included in DocBlocks