Feature: add @wordpress/scripts build process for GiveWP 3.0
#6862
Conversation
jonwaldstein
requested review from
JasonTheAdams,
ravinderk and
kjohnson
and removed request for
JasonTheAdams and
ravinderk
|
@JasonTheAdams @kjohnson this is ready for review. cc: @ravinderk this is how we'll be handling v3 related form scripts including new gateways. |
There was a problem hiding this comment.
Good work, @jonwaldstein! I had a couple minor questions and one suggestion.
| # @wordpress/scripts build directory | ||
| build | ||
| **/build.* | ||
| **/build.asset.* |
There was a problem hiding this comment.
Should anything be added to the .distignore file?
There was a problem hiding this comment.
I don't think so, I assume we want to keep the build folder for distribution since it contains the generated scripts.
There was a problem hiding this comment.
Yeah, the /build folder probably needs to be included in the distribution, instead of trying to mess with moving that target directory.
There was a problem hiding this comment.
@jonwaldstein For sure! I'm really thinking about if there are any specific files (file maps?) within the build that shouldn't be included in distribution.
There was a problem hiding this comment.
Gotchya, it appears wp scripts does not generate those file maps so we should be good. If anything looks weird during distribution we can add to the distignore.
|
@JasonTheAdams ready for re-review |
There was a problem hiding this comment.
Great work, @jonwaldstein! Nice to have this done for the merge!
Description
This adds
@wordpress/scriptsfor building our v3 forms related scripts. The entry point for these scripts are inwepback.config.js.Affects
This only affects new scripts being added to
wepback.config.jsVisuals
N/A
Testing Instructions
npm run dev:v3npm run build:v3npm run watch:v3npm run buildruns both mix and wp-scripts for productionPre-review Checklist
@unreleasedtags included in DocBlocks