Feat: allow admin to select Advanced or Standard card processing connection when onboarding PayPal donations

[ravinderk]

Description

This pull request implements a feature to allow the admin to select an Advanced or Standard card processing connection when onboarding PayPal donations.

Affects

PayPal Donations admin onboarding user flow.

Visuals

Testing Instructions

Admin should able to onboard to PayPal donations without any error.

• A modal should display to admin to select account type when click on connect button.
• Admin should only see smart buttons if admin selects standard card processing.
• Admin should see smart buttons and hosted card fields if admin selects advance card processing.

Pre-review Checklist

• Acceptance criteria satisfied and marked in related issue
• Relevant @unreleased tags included in DocBlocks
• Includes unit tests
• Reviewed by the designer (if follows a design)
• Self Review of code and UX completed

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1204983101380274
  • https://app.asana.com/0/0/1205196925356876

[ravinderk]

Nice progress, @ravinderk! I left a couple comments. Also, when I switched to a country that did not support PPCP and clicked "Connect with PayPal Live" it just switched the button to "Processing..." for a moment and then flipped back, never displaying the PayPal modal.

I believe this is because we haven't deployed the server. Anything holding us back from taking the server changes live?

@JasonTheAdams You can merge and deploy https://github.com/impress-org/givewp-gateway-server/pull/21.

[JasonTheAdams]

@ravinderk I'm trying to get the gateway server working locally. In the meantime, I noticed that if there's an issue fetching the Partner Link the UI just does nothing. No error message or anything. We should inform the user:

There was an issue retrieving a link to connect to PayPal. Please try again. If the issue continues please contact an administrator.

[JasonTheAdams]

@ravinderk I also just noticed that if the connect button is visited the icon disappears.

[ravinderk]

@ravinderk I'm trying to get the gateway server working locally. In the meantime, I noticed that if there's an issue fetching the Partner Link the UI just does nothing. No error message or anything. We should inform the user:

There was an issue retrieving a link to connect to PayPal. Please try again. If the issue continues please contact an administrator.

Resolved a836db5

@ravinderk I also just noticed that if the connect button is visited the icon disappears.

Resolved 7e0e57e

[ravinderk]

@JasonTheAdams I implemented the feature as you requested in slack.

Fix: 2e7c636

[JasonTheAdams]

@ravinderk Let's get rid of the "APIs Connected" text, as it's kind of meaningless.

[ravinderk]

@ravinderk Let's get rid of the "APIs Connected" text, as it's kind of meaningless.

Fixed: 086bf6f

[jdghinson]

@ravinderk Let's get rid of the "APIs Connected" text, as it's kind of meaningless.

Fixed: 086bf6f

@ravinderk Please change the "disconnect" color from blue to red

[ravinderk]

@jdghinson

@ravinderk Please change the "disconnect" color from blue to red

fixed: 74f06d4

[JasonTheAdams]

Great work, @ravinderk! Let's release the gateway and then send this to QA!

[rickalday]

Passed manual QA tests