Add support for next gen form in PayPal Commerce payment gateway

[ravinderk]

Description

This pull request improves PayPal Donations compatibility with Next Gen donation forms.

List of improvements:

• Move recurring donation-related code to recurring add-on https://github.com/impress-org/give-recurring/pull/1188
• Add format data validation and error handling for smart buttons. The donation form validates when the donor clicks on the donate button but PayPal smart buttons have different payment flows. Donors can process the payment on the client site after that on the server we use donation or subscription ID to complete donations, for this reason, form validation checks do not trigger. We trigger format validation checks manually when the donor clicks on any PayPal smart button.
• PayPal donations support two payment method smart buttons and hosted card fields. I implemented an admin setting to control the payment method display in the donation form (Feat: display Paypal payment method type as per admin setting #6835). I added logic to handle this.
• Refactor code to use PayPalCommerceGateway as the main payment gateway class.
• Implement 3D secure validation for hosted card fields.

Affects

This pull request affects donations processing with next-gen donation forms with PayPal donations.

Testing Instructions

Note:

1. PayPal donations support recurring donations with hosted card fields only in v2 donation forms. You can process subscriptions with next-gen donation forms with PayPal smart buttons.
2. Use this pull request for subscription testing: https://github.com/impress-org/give-recurring/pull/1188

Testing credit cards: https://developer.paypal.com/tools/sandbox/card-testing/

• PayPal donations display in next-gen forms based on the Payment Field Type setting value
• Donors should able to process one-time and recurring donations with next-gen donation forms
• Donors should be able to cancel donations
• PayPal donations should be compatible with v2 and next-gen donation forms.

Pre-review Checklist

• Acceptance criteria satisfied and marked in related issue
• Relevant @unreleased tags included in DocBlocks
• Includes unit tests
• Reviewed by the designer (if follows a design)
• Self Review of code and UX completed

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1205392656303316

[ravinderk]

@JasonTheAdams I am working with @jonwaldstein on a known issue about scrolling to the error field or message: slack discussion

But I think you can continue to review.

[JasonTheAdams]

@ravinderk Cool. I'd actually prefer @jonwaldstein to review this since he's more familiar with the existing PayPal Donations v3 integration.

[ravinderk]

@jonwaldstein I added a few fixes to scroll to an invalid field and error message: d949003 2ab5ec8

[jonwaldstein]

@ravinderk can you help me understand what these improvements to PayPal donation are? I have no idea what these updates are for. I might also need to call upon @kjohnson to help test this out because he added the initial v3 support for PayPal donations and is much more familiar with this particular gateway integration than me.

[ravinderk]

@ravinderk can you help me understand what these improvements to PayPal donation are? I have no idea what these updates are for. I might also need to call upon @kjohnson to help test this out because he added the initial v3 support for PayPal donations and is much more familiar with this particular gateway integration than me.

@jonwaldstein I added the list of improvements in the pull request description and requested a review from @kjohnson.

[ravinderk]

@kjohnson Pr is ready to review again

[kjohnson]

@ravinderk thanks for making those changes. Let's get this to QA.

[rickalday]

Passed manual QA tests.

[rickalday]

Passed manual QA tests.