Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add donate button caption to form settings #6883

Merged
merged 13 commits into from
Aug 24, 2023
Merged

Feature: Add donate button caption to form settings #6883

merged 13 commits into from
Aug 24, 2023

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Aug 17, 2023 •
edited
Loading

Description

This PR adds a new form setting, allowing users to edit the button caption for the 'donate now' button/submit button. The applied changes will display on all 3 templates.

Visuals

Screen Shot 2023-08-17 at 8 58 26 AM
Screen.Recording.2023-08-17.at.9.03.33.AM.mov

Testing Instructions

  • Add a v3 form.
  • Use the Form Settings tab and use the Donate Button setting to update the button caption.
  • Verify the button caption has been updated for all 3 form templates.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh changed the title Feature: Add donate button form setting Feature: Add donate button caption to form settings Aug 18, 2023
rickalday
rickalday approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@JoshuaHungDinh JoshuaHungDinh merged commit f03c570 into epic/givewp-3.0 Aug 24, 2023
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the feature/donate-button-caption branch August 24, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonwaldstein jonwaldstein jonwaldstein approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaHungDinh @rickalday @jonwaldstein