Feature: save title as pageslug on publish #7052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwaldstein
requested changes
Oct 23, 2023
src/FormBuilder/resources/js/form-builder/src/containers/HeaderContainer.tsx
Outdated
Show resolved
Hide resolved
src/FormBuilder/resources/js/form-builder/src/settings/form-summary/page-slug.js
Show resolved
Hide resolved
ravinderk
reviewed
Oct 24, 2023
src/FormBuilder/resources/js/form-builder/src/containers/HeaderContainer.tsx
Outdated
Show resolved
Hide resolved
ravinderk
reviewed
Oct 24, 2023
src/FormBuilder/resources/js/form-builder/src/settings/form-summary/page-slug.js
Outdated
Show resolved
Hide resolved
jonwaldstein
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Asana task: https://app.asana.com/0/1205428662243164/1205735215345414/f
Description
This PR saves the form title as the page slug when a form first publishes. After a form has been published the page slug can still be edited, however it is not respective of the form title on any subsequent change.
If the form title is not updated on the first publish the page slug will continue to to work as it previously did, generating the slug trailing with a new number.
I had looked into a central way of dispatching this in the onSave function call - however had inconsistent state changes and the page slug was being overwritten on refresh. Due to this I've opted to include conditional dispatch call's for the page slug on both form title controls.
Re: https://lw.slack.com/archives/C05QFUQ805V/p1697494770284989?thread_ts=1694639392.259359&cid=C05QFUQ805V
Visuals
Screen.Recording.2023-10-23.at.12.02.50.PM.mov
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocks