Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Fix: Prevent fatal error on save posts or pages with [give_multi_form_goal] shortcode #7061

Merged
merged 5 commits into from
Oct 21, 2023

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Oct 20, 2023

Resolves #7060

Description

We are getting a fatal error when users try to use the multi-form shortcode with the ids attribute.

Something like this: [give_multi_form_goal ids="31,39]

This PR fixes this bug - by returning the proper data type in the getForms() method - and allows users to use the ids attribute without throwing any fatal error.

Affects

The give_multi_form_goal shortcode.

Testing Instructions

  1. Add the Multi-Form Goal Shortcode to a page or post and include the "ids" parameter to only include one or more forms. Example: [give_multi_form_goal ids="31,39]
  2. Click on "Update"
  3. No fatal errors should be thrown and the form should get updated without problems.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva marked this pull request as ready for review October 20, 2023 17:32
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G2G in my tests.

@glaubersilva glaubersilva changed the title Hot Fix: Prevent fatal error on save post or page with [give_multi_form_goal] shortcode Hot Fix: Prevent fatal error on save posts or pages with [give_multi_form_goal] shortcode Oct 20, 2023
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

@angelablake angelablake merged commit 8fd8f4c into master Oct 21, 2023
20 checks passed
@angelablake angelablake deleted the hotfix/multi-form-goal-shortcode-7060 branch October 21, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants