-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot Fix: multi-form goal block breaks from filter/form settings #7069
Hot Fix: multi-form goal block breaks from filter/form settings #7069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested & working. Nice - I never found any supporting documentation for using externals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests
…content' populated
… reference for _give_redirect_form_id to prevent warnings on PHP 8.0.1 or plus
… reference for _give_redirect_form_id to prevent warnings on PHP 8.0.1 or plus
… reference for _give_redirect_form_id to prevent warnings on PHP 8.0.1 or plus
c08d659
to
8509651
Compare
Resolves #7068 and #6228 and #7070
Description
The main thing that this PR fixes is the "This block has encountered an error, and can not be previewed" error message displayed on the multi-form goal block when we try to filter the forms that should be used in the progress bar of the block.
The problem was happening because Gutenberg provides its own versions of React and ReactDOM. So, we have to tell third-party libraries about those versions by mapping the package names to the global variables available in the block editor.
Reference: JedWatson/react-select#4893 (comment)
This PR also fixes a problem related to the form titles in the multi-select dropdown, it was displaying
–
instead of-
in the form titles that contain this character.This PR also fixes a bug that prevents a few shortcodes from respecting their own "ids" attribute, like for example these ones:
[give_multi_form_goal ids="931"]
[give_form_grid ids="931"]
[give_totals ids="931" message="Thanks to you, we’ve raised {total} across all our congregations combined! Let's keep it up!" progress_bar="false"]
Affects
Multi-Form Goal Block > Progress Bar > Filters
Visuals
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks