Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: resolve donor details page error when they have no donations #7133

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Fix: resolve donor details page error when they have no donations #7133

merged 2 commits into from
Dec 20, 2023

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Dec 7, 2023 •
edited by jira bot
Loading

Resolves #7130, GIVE-146

Description

This fixes an error on the donor details page when the donor has no donations.

Affects

  • Donor details page

Visuals

Before:

Screenshot 2023-12-07 at 11 16 54 AM

After:

Screenshot 2023-12-07 at 11 22 47 AM

Testing Instructions

Test for Donors with and without donations

  • Create a donor with donations
  • Create a donor without donations
  • View both donor details pages

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the title Fix: resolve donor details error when they have no donations Fix: resolve donor details page error when they have no donations Dec 7, 2023
@jonwaldstein jonwaldstein marked this pull request as ready for review December 7, 2023 16:26
@jonwaldstein jonwaldstein changed the base branch from develop to master December 7, 2023 16:26
@jonwaldstein
Copy link
Contributor Author

jonwaldstein commented Dec 7, 2023 •
edited
Loading

Dev note:

Our model relationships use the ModelQueryBuilder and can result in null. Currently, we are not accounting for null in our doc blocks and should either add null to these relationships or have them return empty arrays (in the near future).

@jonwaldstein
Copy link
Contributor Author

@kjohnson this is ready for review.

rickalday
rickalday approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests.

@jonwaldstein jonwaldstein merged commit c473669 into master Dec 20, 2023
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/GIVE-146 branch December 20, 2023 18:58
@kjohnson kjohnson mentioned this pull request Jan 22, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjohnson kjohnson kjohnson approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jonwaldstein @rickalday @kjohnson