Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: narrow scope of checking if editing v2 forms #7135

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix: narrow scope of checking if editing v2 forms #7135

merged 2 commits into from
Dec 13, 2023

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Dec 7, 2023 •
edited by jira bot
Loading

Resolves #7092, GIVE-1

Description

Replaced logic for checking if editing v2 forms to be give_forms post_type specific to avoid showing up on unrelated WordPress pages.

Affects

  • v2 donation form admin page editing conditional

Visuals

N/A

Testing Instructions

  • As an admin, go to /wp-admin/nav-menus.php to edit menus (make sure you have WP_DEBUG set to true)
  • You should not get this visual error:
Screenshot 2023-12-07 at 12 00 39 PM

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein marked this pull request as ready for review December 8, 2023 20:21
@jonwaldstein
Copy link
Contributor Author

@JoshuaHungDinh or @alaca this is ready for review.

alaca
alaca approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

rickalday
rickalday approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests

@jonwaldstein jonwaldstein removed the request for review from JoshuaHungDinh December 13, 2023 14:29
@jonwaldstein jonwaldstein merged commit 9288a9d into master Dec 13, 2023
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/GIVE-1 branch December 13, 2023 17:34
@jonwaldstein jonwaldstein mentioned this pull request Dec 13, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaca alaca alaca approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonwaldstein @rickalday @alaca