-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add Constant Contact add-on to the form migration process #7145
Feature: add Constant Contact add-on to the form migration process #7145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
…rearrange constant contact methods next to eachother.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoshuaHungDinh great job man!! You are a unit test writing machine now 🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed QA tests.
Resolves: GIVE-176
Description
This PR includes a form migration step for the new Constant Contact block migrating from a v2 form to a v3 form. I also removed the commented section of supported addons for Constant Contact so that it will display on our list when upgrading.
Cases when the block should be added.
Testing Instructions with updated visuals
ConsatantContact-FOIRM-SETTINGS.mov
GlLOBAL-SETTINGS.mov
Pre-review ChecklistT
@unreleased
tags included in DocBlocks