Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add Constant Contact add-on to the form migration process #7145

Merged
merged 16 commits into from
Apr 10, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Dec 13, 2023

Resolves: GIVE-176

Description

This PR includes a form migration step for the new Constant Contact block migrating from a v2 form to a v3 form. I also removed the commented section of supported addons for Constant Contact so that it will display on our list when upgrading.

Cases when the block should be added.

  • While Constant Contact is globally enabled on all forms, if the form is not explicitly disabled from the per form setting migrating should add the block.
  • While Constant Contact is not globally enabled if it is explicitly enabled on the per form setting than migrating should add the block.

Testing Instructions with updated visuals

ConsatantContact-FOIRM-SETTINGS.mov
GlLOBAL-SETTINGS.mov
  • Use New Constant Contact Block
  • Set your global settings
  • add a v2 form -> then migrate the form without editing the form settings.
  • Verify the v3 form has the correct settings set from the global options.
  • Create another v2 form -> update the per-form settings on the right -> then migrate the form
  • Verify the v3 form has the correct settings set from the form options.

Pre-review ChecklistT

  • Relevant @unreleased tags included in DocBlocks
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh changed the title Feature/constantcontact form migration give 64 Feature: add form migration step for Constant Contact Dec 13, 2023
@JoshuaHungDinh JoshuaHungDinh changed the title Feature: add form migration step for Constant Contact Feature: add form migration step for Constant Contact [GIVE-64] Dec 13, 2023
@JoshuaHungDinh JoshuaHungDinh changed the title Feature: add form migration step for Constant Contact [GIVE-64] Feature: add form migration step for Constant Contact Dec 13, 2023
@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review December 14, 2023 06:17
@JoshuaHungDinh JoshuaHungDinh changed the title Feature: add form migration step for Constant Contact Feature: add form migration step for Constant Contact [GIVE-64] Dec 14, 2023
@JoshuaHungDinh JoshuaHungDinh changed the title Feature: add form migration step for Constant Contact [GIVE-64] Feature: add form migration step for Constant Contact - [GIVE-64] Dec 14, 2023
@JoshuaHungDinh JoshuaHungDinh changed the title Feature: add form migration step for Constant Contact - [GIVE-64] Feature: add form migration step for Constant Contact Dec 14, 2023
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@JoshuaHungDinh JoshuaHungDinh changed the title Feature: add form migration step for Constant Contact Feature: add Constant Contact add-on to the form migration process Jan 2, 2024
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshuaHungDinh great job man!! You are a unit test writing machine now 🤩

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests.

@jonwaldstein jonwaldstein merged commit 5972f7e into develop Apr 10, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the feature/constantcontact-form-migration-GIVE-64 branch April 10, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants