PHP 8.2 compatibility #7147
Merged
PHP 8.2 compatibility #7147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjohnson
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Looks good to me.
As for the packages/dependencies, I think it is fine to merge these changes and address the dependencies at a later time. We can't control their notices and I certainly don't want to invest time to potentially replacing them over deprecated notices at this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7141
Description
This PR adds PHP 8.2 compatibility to Give Core, but it fails to do that 100% since we use packages that we can't update without bumping the min required PHP version for Give Core.
Packages that require updates:
moneyphp/money
Currently, we use v3.3.1 which throws notices running on servers that use PHP 8.2
To fix this we have to update this package to v4.0.0. The problem is that this version requires PHP ^8.0
myclabs/php-enum
Currently, we use v1.6 which throws notices running on servers that use PHP 8.2
To fix this we have to update this package to ^1.8.0. The problem is that this version requires PHP ^7.3
Affects
Give Core
Testing Instructions
Install Give on server that runs PHP 8.2
Enable
WP_DEBUGandWP_DEBUG_LOGAdd donation forms
Make donations
Edit donors
Preview forms on frontend
Browse admin pages
Check if there are any notices inside the debug.log file related to Give core
Pre-review Checklist
@unreleasedtags included in DocBlocks