Fix: Remove default value for continue_button_title - [GIVE-145]
#7153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7150 / GIVE-145
Description
This PR removes the static default value for
continue_button_titlein the shortcode args, so that form meta can be used as the default for legacy forms. We still require a default value for v3 forms, so one has been added to theBlockAttributesclass.Also I found a duplicate line for
$formUrlin theBlockRenderControllerthat I removed. It was an oversight while merging Feature: include shortcode & block control support for v3 forms #7082 and Feature: Embed Donation Form button #7080Affects
Legacy Forms, shortcode, block
Visuals
Screen.Recording.2023-12-18.at.11.48.03.AM.mov
Testing Instructions
Pre-review Checklist