-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add telemetry for the Event block #7341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjohnson
commented
Apr 8, 2024
pauloiankoski
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Build for QA, see https://github.com/impress-org/givewp/actions/runs/8742421542. |
Build for QA, see https://github.com/impress-org/givewp/actions/runs/8836423379 |
kjohnson
commented
Apr 25, 2024
Build for QA, see https://github.com/impress-org/givewp/actions/runs/8838257778 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-505.
Resolves GIVE-506.
Related https://github.com/impress-org/give-telemetry-server/pull/18.
Description
This PR introduces 2 new data points to the telemetry (tracking) system:
DonationFormsData
->event_block
GivePluginSettingsData
->is_event_tickets
Supporting this change is a new
Helpers/FormBlocks
class, which abstracts access to theBlockCollection
to confirm a block's existence by name.