Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add telemetry for the Event block #7341

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

kjohnson
Copy link
Member

@kjohnson kjohnson commented Apr 4, 2024

Resolves GIVE-505.
Resolves GIVE-506.

Related https://github.com/impress-org/give-telemetry-server/pull/18.

Description

This PR introduces 2 new data points to the telemetry (tracking) system:

  • DonationFormsData -> event_block
  • GivePluginSettingsData -> is_event_tickets

Supporting this change is a new Helpers/FormBlocks class, which abstracts access to the BlockCollection to confirm a block's existence by name.

@kjohnson kjohnson marked this pull request as ready for review April 4, 2024 18:19
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kjohnson
Copy link
Member Author

@kjohnson
Copy link
Member Author

@kjohnson
Copy link
Member Author

@kjohnson kjohnson merged commit 07afc8d into develop Apr 29, 2024
20 checks passed
@kjohnson kjohnson deleted the feature/event-block-telemetry-GIVE-386 branch April 29, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants