Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Update DonationAmountLevels template to support descriptions #7363

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Apr 23, 2024

Resolves GIVE-626

Description

Update the DonationAmountLevels component to include levels with descriptions. Display a group of levels with descriptions first, followed by the remaining ones.

If no levels have descriptions, show all options in a grid. If at least one level has a description, present the flexible interface below.

It is important to note that these groups respect the order set in the admin, but within each group.

Affects

Donation Amount Levels template

Visuals

CleanShot.2024-04-23.at.18.32.38.mp4

Variations with 4, 3, 2, 1 and 0 remaining options with no description

CleanShot 2024-04-23 at 18 33 37
Same options from above but after disabling descriptions

Testing Instructions

  1. Enable Donation Levels in VFB.
  2. Ensure the Donation Form resembles the current design.
  3. Return to VFB, activate descriptions, and include some.
  4. Check how the Donation Form displays options in a new way.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@pauloiankoski pauloiankoski force-pushed the feature/level-descriptions-frontend-ui branch from 73edb86 to c8c54f8 Compare April 24, 2024 00:46
@pauloiankoski pauloiankoski merged commit 5d1ddd8 into epic/donation-amount-level-descriptions Apr 24, 2024
20 checks passed
@pauloiankoski pauloiankoski deleted the feature/level-descriptions-frontend-ui branch April 24, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants