Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update Currency Switcher integration #7366

Conversation

pauloiankoski
Copy link
Contributor

Description

This pull request updates the integration for Donation Amount Levels with Currency Switcher. The schema has been changed from an array of numbers to an array of objects. It also updates some remaining prop types.

Affects

Currency Switcher on Amount Levels

Visuals

CleanShot.2024-04-24.at.16.26.09.mp4

Testing Instructions

  1. Configure Currency Switcher and Donation Levels
  2. Make sure they still work as expected.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G2G

@pauloiankoski pauloiankoski merged commit 6bd5350 into epic/donation-amount-level-descriptions Apr 24, 2024
20 checks passed
@pauloiankoski pauloiankoski deleted the fix/update-currency-switcher-integration branch April 24, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants