-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: donation confirmation page redirect #7439
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwaldstein
changed the title
Spike: donation confirmation page redirect
Feature: donation confirmation page redirect
Jul 12, 2024
Yeahhh! I've been wanting this feature for years! 😭 🙌 |
alaca
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff! Nice job, @jonwaldstein
rickalday
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-704
Description
This adds the ability for a donation form to redirect to the success page defined in GiveWP global settings.
In addition to the form builder settings, more flexibility can be applied using the filters below:
Global
Per-form enable
Per-form permalink
Affects
This affects the donation confirmation page rendering of the give_receipt shortcode. Since this is a shared page and shortcode with v2 and v3 forms, we'll want to make sure v2 forms are still working as expected along the way.
The approach taken was to add carefully placed actions and filters in the existing v2 logic so we can hook into them for the purposes of v3 forms. These include:
give_donation_confirmation_page_enqueue_scripts
give_receipt_shortcode_output
give_donation_confirmation_success_page_shortcode_view
Visuals
Demo Video:
https://www.loom.com/share/eed72b9765a44301afa5956178badfbd?sid=535e20ea-4417-4609-8fe9-e92f41b36aa1
Testing Instructions
ZIP: https://github.com/impress-org/givewp/actions/runs/10219452643
Form settings
Test the filters
add_filter( 'givewp_donation_confirmation_page_redirect', '__return_true' );
give_receipt
shortcodePre-review Checklist
@unreleased
tags included in DocBlocks