-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add campaign pages #7510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…give into feature/campaign-pages-1150
alaca
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
glaubersilva
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kjohnson Great work! Just left a couple of comments related to small string tweaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-1150
Description
This PR introduces the Campaign Page, which can be customized via the Block Editor.
From the campaign list table (coming soon), the campaign page can be accessed via
/wp-admin/?action=edit_campaign_page&campaign_id={id}
.The Campaign Page model is created "on demand" when attempting to customize the page content (see the testing instructions). Ideally, this provides us flexibility to update the "default" state of the page when not customized (as blocks can be complicated to update if created ahead of time).
Note: This does not include front-end routing of the Campaign for publicly rendering the page content.
Affects
The Campaign/Page relationship has been moved to the CampaignPage class, which now stores the related
campaignId
as a property (as opposed to the Campaign having apageId
property). This prevents broken references to a CampaignPage when the underlying post is deleted or trashed.Visuals
Testing Instructions
With a Campaign created (manually or via the database), go to
/wp-admin/?action=edit_campaign_page&campaign_id={id}
to be redirected to the related campaign page in the Block Editor.Pre-review Checklist
@unreleased
tags included in DocBlocks