Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: update strings translations (@DAnn2012) #7512

Merged
merged 9 commits into from
Aug 26, 2024

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Aug 22, 2024

Resolves GIVE-1159

Description

This includes all PR submissions from @DAnn2012 to update string translations

Affects

Strings in following locations:

  • Donation and Subscription list tables
  • Form builder embed
  • Form summary block
  • Form builder email options
  • GiveWP global advanced settings
  • Recurring donations promo in form builder

Visuals

N/A

Testing Instructions

  • Run through automated tests
  • Make sure affected pages work as expected

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein marked this pull request as ready for review August 22, 2024 19:59
Co-authored-by: Kyle B. Johnson <[email protected]>
Co-authored-by: Jon Waldstein <[email protected]>
Co-authored-by: Paulo Iankoski <[email protected]>
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual tests.

@jonwaldstein jonwaldstein merged commit b983c95 into develop Aug 26, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the feature/DAnn2012-add-translations branch August 26, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants