-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add campaign details page header with tabs, save buttons, and form with sample input #7536
Feature: add campaign details page header with tabs, save buttons, and form with sample input #7536
Conversation
Great progress, @glaubersilva! @alaca @kjohnson @jonwaldstein This is a good example of why I think it would be a good idea to set up the Data API as soon as possible. All of the state described here would work well within the store. It also wouldn't have the same rendering issues as the Context API. As a note, we'd also be able to use the Redux dev tools to start to do things like watch, edit, and rewrite state changes for debugging. |
@kjohnson Thanks for the suggestions. I already implemented them. Let me know if there is something else. About the admin notices, those are displayed after the I think it would be a bit weird to display the notices before the tabs because the tabs and the header seem to be one single thing, different from the event details page where the tabs navigation and the head have different colors - check the attached screenshots for reference. Event Details Page - Notices before the tabs navegation: Campaign Details Page - Notices before the tabs navegation: Campaign Details Page - Notices after the tabs navegation: |
Resolves GIVE-1218
Description
This PR implements the campaign details page with the following items:
react-hook-form
to keep the context through the different tabsThis will require a subsequent PR for design review, but the main functionality is already in place. The idea here is to move forward with the project and not block the rest of the team that is depending on this screen to keep going on their tasks.
Affects
The campaign details page.
Visuals
https://www.loom.com/share/f690359235444dc38bad921c4616e2b8?sid=c2137137-c1e0-41e6-9b06-37056dc87eba
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks