Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add global settings for honeypot field #7546

Merged
merged 14 commits into from
Oct 15, 2024

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Sep 20, 2024

Resolves GIVE-1252

Description

This adds a global setting to enable the honeypot field for v3 forms. This introduces a new section to the "general" tab called security.

Affects

When this settings is enabled, it will affects v3 forms by programmatically adding a honeypot field.

Additional filter added for the honeypot field name:

apply_filters('givewp_donation_forms_honeypot_field_name', $fieldName, $formId)

Visuals

Screenshot 2024-10-15 at 10 08 31 AM

Testing Instructions

  • Enable the new settings
  • Interact with a v3 form

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the title Feature: add global settings for donation forms honeypot field Feature: add global settings for honeypot field Sep 20, 2024
@jonwaldstein jonwaldstein marked this pull request as ready for review September 20, 2024 17:31
@kjohnson kjohnson self-requested a review September 20, 2024 17:49
Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual and automated tests.

@jonwaldstein jonwaldstein merged commit 2b5a79e into develop Oct 15, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the feature/honeypot-field-setting branch October 15, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants