-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add "Make as default" action to the forms list view #7606
Feature: add "Make as default" action to the forms list view #7606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accidentally approved this PR. I mean, it looks good, but I would like to see this a bit more organized. See my previous comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glaubersilva after testing this, it looks like setting the default form doesn't work. After clicking on the link, I get the option to set the default form for all forms in the list table.
@alaca Make sure to run the Let me know if you were able to make it work and if there is anything else to change. |
@glaubersilva it looks like it is related to V2 forms. Screen.Recording.2024-11-06.at.18.32.12.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @glaubersilva nice job, man. There are some things that I would like to do differently and would like to hear what you think.
src/DonationForms/V2/resources/components/DonationFormsRowActions.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, man! 👍
I'll do some refactoring on the forms
and defaultForm
methods in separate PR.
Just resolve the failing tests before merging.
@glaubersilva hey man, where is the route that makes form default? 😅 |
Resolves GIVE-1333
Description
This PR adds a "Make as default" action in the forms list table which lives on the forms tab from the campaigns details page.
Affects
The forms list table.
Visuals
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks