Refactor: Default form

src/Campaigns/Actions/ConvertQueryDataToCampaign.php

@@ -20,6 +20,7 @@ public function __invoke(object $queryObject): Campaign
     {
         return new Campaign([
             'id' => (int)$queryObject->id,
+            'defaultFormId' => (int)$queryObject->defaultFormId,
             'type' => new CampaignType($queryObject->type),
             'title' => $queryObject->title,
             'shortDescription' => $queryObject->shortDescription,

src/Campaigns/Actions/LoadCampaignDetailsAssets.php

@@ -4,7 +4,6 @@
 
 use Give\Campaigns\Models\Campaign;
 use Give\Framework\Support\Facades\Scripts\ScriptAsset;
-use Give\Helpers\Form\Utils;
 
 /**
  * @unreleased
@@ -34,13 +33,12 @@ public function __invoke()
         );
 
         $defaultForm = $campaign->defaultForm();
-        $defaultFormTitle = Utils::isV3Form($defaultForm->id) ? $defaultForm->settings->formTitle : $defaultForm->title;
         wp_localize_script($handleName, 'GiveCampaignDetails',
             [
                 'adminUrl' => admin_url(),
                 'currency' => give_get_currency(),
                 'isRecurringEnabled' => defined('GIVE_RECURRING_VERSION') ? GIVE_RECURRING_VERSION : null,
-                'defaultForm' => $defaultFormTitle,
+                'defaultForm' => $defaultForm->title,
             ]
         );
 

src/Campaigns/Controllers/CampaignRequestController.php

@@ -125,8 +125,7 @@ public function updateCampaign(WP_REST_Request $request)
                     $campaign->goalType = new CampaignGoalType($value);
                     break;
                 case 'defaultFormId':
-                    give(CampaignRepository::class)->updateDefaultCampaignForm($campaign,
-                        $request->get_param('defaultFormId'));
+                    give(CampaignRepository::class)->updateDefaultCampaignForm($campaign, $request->get_param('defaultFormId'));
                     break;
                 default:
                     if ($campaign->hasProperty($key)) {
@@ -142,6 +141,21 @@ public function updateCampaign(WP_REST_Request $request)
         return new WP_REST_Response($campaign->toArray());
     }
 
+    /**
+     * @unreleased
+     *
+     * @throws Exception
+     */
+    public function mergeCampaigns(WP_REST_Request $request): WP_REST_Response
+    {
+        $destinationCampaign = Campaign::find($request->get_param('id'));
+        $campaignsToMerge = Campaign::query()->whereIn('id', $request->get_param('campaignsToMergeIds'))->getAll();
+
+        $campaignsMerged = $destinationCampaign->merge(...$campaignsToMerge);
+
+        return new WP_REST_Response($campaignsMerged);
+    }
+
 
     /**
      * @unreleased

src/Campaigns/Migrations/MigrateFormsToCampaignForms.php

@@ -116,6 +116,7 @@ public function createCampaignForForm($formData): void
 
         DB::table('give_campaigns')
             ->insert([
+                'form_id' => $formId,
                 'campaign_type' => 'core',
                 'campaign_title' => $formTitle,
                 'status' => $this->mapFormToCampaignStatus($formStatus),
@@ -134,27 +135,26 @@ public function createCampaignForForm($formData): void
 
         $campaignId = DB::last_insert_id();
 
-        $this->addCampaignFormRelationship($formId, $campaignId, true);
+        $this->addCampaignFormRelationship($formId, $campaignId);
     }
 
     /**
      * @param $data
      */
     protected function addUpgradedFormToCampaign($data): void
     {
-        $this->addCampaignFormRelationship($data->migratedFormId, $data->campaignId, false);
+        $this->addCampaignFormRelationship($data->migratedFormId, $data->campaignId);
     }
 
     /**
      * @unreleased
      */
-    protected function addCampaignFormRelationship($formId, $campaignId, $isDefault)
+    protected function addCampaignFormRelationship($formId, $campaignId)
     {
         DB::table('give_campaign_forms')
             ->insert([
                 'form_id' => $formId,
-                'campaign_id' => $campaignId,
-                'is_default' => $isDefault,
+                'campaign_id' => $campaignId
             ]);
     }
 

src/Campaigns/Migrations/Tables/CreateCampaignFormsTable.php

@@ -51,7 +51,6 @@ public function run(): void
         $sql = "CREATE TABLE $table (
             campaign_id INT UNSIGNED NOT NULL,
             form_id INT UNSIGNED NOT NULL,
-            is_default BOOLEAN NOT NULL DEFAULT 0,
             KEY form_id (form_id),
             KEY campaign_id (campaign_id),
             PRIMARY KEY (campaign_id, form_id)

src/Campaigns/Models/Campaign.php

@@ -11,8 +11,8 @@
 use Give\Campaigns\ValueObjects\CampaignGoalType;
 use Give\Campaigns\ValueObjects\CampaignStatus;
 use Give\Campaigns\ValueObjects\CampaignType;
-use Give\DonationForms\Models\DonationForm;
-use Give\DonationForms\V2\Models\DonationForm as LegacyDonationForm;
+use Give\DonationForms\V2\Models\DonationForm;
+use Give\DonationForms\V2\Repositories\DonationFormsRepository;
 use Give\Framework\Exceptions\Primitives\InvalidArgumentException;
 use Give\Framework\Models\Contracts\ModelCrud;
 use Give\Framework\Models\Contracts\ModelHasFactory;
@@ -24,6 +24,7 @@
  * @unreleased
  *
  * @property int              $id
+ * @property int              $defaultFormId
  * @property CampaignType     $type
  * @property string           $title
  * @property string           $url
@@ -47,6 +48,7 @@ class Campaign extends Model implements ModelCrud, ModelHasFactory
      */
     protected $properties = [
         'id' => 'int',
+        'defaultFormId' => 'int',
         'type' => CampaignType::class,
         'title' => 'string',
         'shortDescription' => 'string',
@@ -65,22 +67,10 @@ class Campaign extends Model implements ModelCrud, ModelHasFactory
 
     /**
      * @unreleased
-     *
-     * @return DonationForm | LegacyDonationForm
      */
-    public function defaultForm()
+    public function defaultForm(): ?DonationForm
     {
-        $defaultForm = $this->forms()
-            ->where('campaign_forms.is_default', true)
-            ->get();
-
-        if (is_null($defaultForm)) {
-            $defaultForm = $this->legacyForms()
-                ->where('campaign_forms.is_default', true)
-                ->get();
-        }
-
-        return $defaultForm;
+        return give(DonationFormsRepository::class)->getById($this->defaultFormId);
     }
 
     /**
@@ -90,21 +80,11 @@ public function forms(): ModelQueryBuilder
     {
         return DonationForm::query()
             ->join(function (JoinQueryBuilder $builder) {
-                $builder->leftJoin('give_campaign_forms', 'campaign_forms')
+                $builder
+                    ->leftJoin('give_campaign_forms', 'campaign_forms')
                     ->on('campaign_forms.form_id', 'forms.id');
-            })->where('campaign_forms.campaign_id', $this->id);
-    }
-
-    /**
-     * @unreleased
-     */
-    public function legacyForms(): ModelQueryBuilder
-    {
-        return LegacyDonationForm::query()
-            ->join(function (JoinQueryBuilder $builder) {
-                $builder->leftJoin('give_campaign_forms', 'campaign_forms')
-                    ->on('campaign_forms.form_id', 'id');
-            })->where('campaign_forms.campaign_id', $this->id);
+            })
+            ->where('campaign_forms.campaign_id', $this->id);
     }
 
     /**

src/Campaigns/Repositories/CampaignRepository.php

@@ -168,24 +168,19 @@ public function addCampaignForm(Campaign $campaign, int $donationFormId, bool $i
         DB::query('START TRANSACTION');
 
         try {
-            // Make sure we'll have only one default form
             if ($isDefault) {
-                DB::table('give_campaign_forms')
-                    ->where('campaign_id', $campaign->id)
+                DB::table('give_campaigns')
+                    ->where('id', $campaign->id)
                     ->update([
-                        'is_default' => false,
+                        'form_id' => $donationFormId,
                     ]);
             }
 
-            $table = DB::prefix('give_campaign_forms');
-            DB::query(
-                DB::prepare("INSERT INTO {$table} (form_id, campaign_id, is_default ) VALUES (%d, %d, %d)",
-                    [
-                        $donationFormId,
-                        $campaign->id,
-                        $isDefault,
-                    ])
-            );
+            DB::table('give_campaign_forms')
+                ->insert([
+                    'form_id' => $donationFormId,
+                    'campaign_id' => $campaign->id,
+                ]);
         } catch (Exception $exception) {
             DB::query('ROLLBACK');
 
@@ -211,13 +206,11 @@ public function updateDefaultCampaignForm(Campaign $campaign, int $donationFormI
         DB::query('START TRANSACTION');
 
         try {
-            DB::query(
-                DB::prepare('UPDATE ' . DB::prefix('give_campaign_forms') . ' SET is_default = IF(form_id = %d, 1, 0) WHERE campaign_id = %d',
-                    [
-                        $donationFormId,
-                        $campaign->id,
-                    ])
-            );
+            DB::table('give_campaigns')
+                ->where('id', $campaign->id)
+                ->update([
+                    'form_id' => $donationFormId
+                ]);
         } catch (Exception $exception) {
             DB::query('ROLLBACK');
 
@@ -293,7 +286,7 @@ public function mergeCampaigns(Campaign $destinationCampaign, Campaign ...$campa
 
             // Migrate forms from campaigns to merge to the destination campaign
             DB::query(
-                DB::prepare("UPDATE " . DB::prefix('give_campaign_forms') . " SET is_default = 0, campaign_id = %d WHERE campaign_id IN ($campaignsToMergeIdsString)",
+                DB::prepare("UPDATE " . DB::prefix('give_campaign_forms') . " campaign_id = %d WHERE campaign_id IN ($campaignsToMergeIdsString)",
                     [
                         $destinationCampaign->id,
                     ])
@@ -343,6 +336,7 @@ public function prepareQuery(): ModelQueryBuilder
         return $builder->from('give_campaigns', 'campaigns')
             ->select(
                 'id',
+                ['form_id', 'defaultFormId'],
                 ['campaign_type', 'type'],
                 ['campaign_title', 'title'],
                 ['short_desc', 'shortDescription'],

src/Campaigns/Routes/RegisterCampaignRoutes.php

@@ -35,6 +35,7 @@ public function __invoke()
         $this->registerGetCampaign();
         $this->registerUpdateCampaign();
         $this->registerGetCampaigns();
+        $this->registerMergeCampaigns();
         $this->registerCreateCampaign();
     }
 
@@ -130,6 +131,44 @@ public function registerUpdateCampaign()
     }
 
 
+    /**
+     * Update Campaign route
+     *
+     * @unreleased
+     */
+    public function registerMergeCampaigns()
+    {
+        register_rest_route(
+            CampaignRoute::NAMESPACE,
+            CampaignRoute::CAMPAIGN . '/merge',
+            [
+                [
+                    'methods' => WP_REST_Server::EDITABLE,
+                    'callback' => function (WP_REST_Request $request) {
+                        return $this->campaignRequestController->mergeCampaigns($request);
+                    },
+                    'permission_callback' => function () {
+                        return current_user_can('manage_options');
+                    },
+                ],
+                'args' => [
+                    'id' => [
+                        'type' => 'integer',
+                        'required' => true,
+                    ],
+                    'campaignsToMergeIds' => [
+                        'type' => 'array',
+                        'required' => true,
+                        'items' => [
+                            'type' => 'integer',
+                        ],
+                    ],
+                ],
+            ]
+        );
+    }
+
+
     /**
      * Create Campaign route
      *

src/Campaigns/ServiceProvider.php

@@ -56,7 +56,6 @@ private function registerRoutes()
         Hooks::addAction('rest_api_init', Routes\GetCampaignsListTable::class, 'registerRoute');
         Hooks::addAction('rest_api_init', Routes\DeleteCampaignListTable::class, 'registerRoute');
         Hooks::addAction('rest_api_init', Routes\GetCampaignStatistics::class, 'registerRoute');
-        Hooks::addAction('rest_api_init', Routes\MergeCampaigns::class, 'registerRoute');
     }
 
     /**